#154 - 쪽지 읽음 처리를 진행합니다. #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements an API endpoint to mark messages as read, along with the necessary domain, service, and controller layer changes.
- Introduces mutable properties isReceiverRead and readAt on MessageV2 and a new read(viewer: User) method.
- Adds the isRead field to the message detail and response DTOs with corresponding mappings.
- Implements a new ReadMessageV2Service and ReadMessageV2Controller to expose the read API endpoint.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| domain/src/main/kotlin/com/wespot/message/v2/MessageV2.kt | Updated message model to allow mutability and added read(viewer: User) method |
| domain/src/main/kotlin/com/wespot/message/v2/MessageDetail.kt | Added isRead field and mapped it via message.isRead(viewer: viewer) |
| core/src/main/kotlin/com/wespot/message/service/v2/ReadMessageV2Service.kt | Created service for handling the message-read operation |
| core/src/main/kotlin/com/wespot/message/port/in/ReadMessageV2UseCase.kt | Defined a new use case interface for reading messages |
| core/src/main/kotlin/com/wespot/message/dto/response/MessageV2DetailsResponse.kt | Updated response DTO to include the read status |
| app/src/main/kotlin/com/wespot/message/v2/ReadMessageV2Controller.kt | Added a controller exposing the new read endpoint |
Comments suppressed due to low confidence (2)
domain/src/main/kotlin/com/wespot/message/v2/MessageDetail.kt:25
- The call 'message.isRead(viewer = viewer)' is not defined in MessageV2. Consider either implementing a computed property or method in MessageV2 that returns the read status based on 'isReceiverRead', or update this call to use the existing property directly.
isRead = message.isRead(viewer = viewer)
core/src/main/kotlin/com/wespot/message/dto/response/MessageV2DetailsResponse.kt:32
- The property 'message.isRead' is used to determine the read status, but MessageV2 only contains 'isReceiverRead'. Consider unifying the API by either adding a computed 'isRead' property/method in MessageV2 or by replacing this reference with 'isReceiverRead'.
isRead = message.isRead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. 🔗 관련 이슈
closes #154
2. 📄 구현한 내용 또는 수정한 내용
5. ✅ 배포 Checklist